Allow Podman to send the container's hostname to Netavark #2254
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtjoseph
added a commit
to gtjoseph/podman
that referenced
this pull request
Nov 25, 2024
Signed-off-by: George Joseph <[email protected]>
|
The |
|
Added field is fine. Makes more sense to me than using the container ID honestly. |
gtjoseph
force-pushed
the
main-netavark-hostname
branch
from
31b6f9e to
eb88c0e
Compare
Luap99
reviewed
Nov 26, 2024
gtjoseph
force-pushed
the
main-netavark-hostname
branch
from
eb88c0e to
a88971b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtjoseph, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
* Added ContainerHostname to NetworkOptions. Podman will set this and Netavark will read it. * Added the `container_name_as_hostname` option to the CONTAINERS table in containers.conf. Currently, if you don't explicitly set a hostname when creating a container, podman will set it to the short ID. If this option set to `true` and a hostname isn't explicitly set, podman will use the container's name, with characters not in the set `[0-9a-zA-Z.-]` removed, as the hostname instead of the short ID. Set to false by default to preserve existing behavior. Signed-off-by: George Joseph <[email protected]>
gtjoseph
force-pushed
the
main-netavark-hostname
branch
from
a88971b to
2a3e1c1
Compare
gtjoseph
added a commit
to gtjoseph/podman
that referenced
this pull request
Nov 28, 2024
Signed-off-by: George Joseph <[email protected]>
gtjoseph
added a commit
to gtjoseph/podman
that referenced
this pull request
Nov 29, 2024
Signed-off-by: George Joseph <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ContainerHostname to NetworkOptions. Podman will set this
and Netavark will read it.
Added the
container_name_as_hostnameoption to theCONTAINERS table in containers.conf. Currently, if you don't
explicitly set a hostname when creating a container, podman will
set it to the short ID. If this option set to
trueand ahostname isn't explicitly set, podman will use the container's
name, with characters not in the set
[0-9a-zA-Z.-]removed,as the hostname instead of the short ID. Set to false by default
to preserve existing behavior.
Signed-off-by: George Joseph [email protected]
Required by containers/podman#24675
Required by containers/netavark#1130